Welcome to SP!  -
Areas & RangesMountains & RocksRoutesImagesArticlesTrip ReportsGearOtherPeoplePlans & PartnersWhat's NewForum

New Editor Feedback & Bug Reports

Suggestions and comments about SummitPost's features, policies, and procedures. Post bugs here.
 

Re: New Editor Feedback & Bug Reports

Postby Montana Matt » Tue Feb 12, 2013 7:41 pm

Scott wrote:Delete photo seems to delete the entire section on the page?

No, but in certain circumstances when editing pages created with the old editor, it could happen.
Montana Matt wrote:If reporting a bug or an issue, please include the following information:
1) The URL of the page where you have the issue
2) A detailed description of the issue
3) Details about what exactly on the page is causing the issue (photo, lists, combinations of photos and lists) and information to easily find and identify these problematic elements.
4) Browser and Operating System that you're using
User Avatar
Montana Matt
Site Admin
 
Posts: 1128
Joined: Sun Apr 11, 2004 10:06 pm
Location: Ashland, Oregon, United States
Thanked: 340 times in 184 posts

Re: New Editor Feedback & Bug Reports

Postby Montana Matt » Tue Feb 12, 2013 7:44 pm

Bob Sihler wrote:Yikes! Whatever was done has made a mess of my page: http://www.summitpost.org/page-workshop/307131

That could have been me. I have made some changes to the image insertion code and I was playing around with that page when I did so.

Have you seen other pages with similar issues?
User Avatar
Montana Matt
Site Admin
 
Posts: 1128
Joined: Sun Apr 11, 2004 10:06 pm
Location: Ashland, Oregon, United States
Thanked: 340 times in 184 posts

Re: New Editor Feedback & Bug Reports

Postby Montana Matt » Tue Feb 12, 2013 7:48 pm

Alpinist wrote:Help! I edited my list of Online Gear Stores today and it broke all of the URLs. I pulled up the previous version through the View History link and tried editing it again using the Old Editor but the links are still broken. That's odd because the URLs appear when I'm editing the page but there are no hyperlinks when I save it...

Please let me know how to revert back to the previous version.

I reverted back to the previous version for you Alpinist. I have also verified that the new editor is causing the problem. Will see if I can figure out a fix.
User Avatar
Montana Matt
Site Admin
 
Posts: 1128
Joined: Sun Apr 11, 2004 10:06 pm
Location: Ashland, Oregon, United States
Thanked: 340 times in 184 posts

Re: New Editor Feedback & Bug Reports

Postby Bob Sihler » Tue Feb 12, 2013 7:56 pm

Montana Matt wrote:
Bob Sihler wrote:Yikes! Whatever was done has made a mess of my page: http://www.summitpost.org/page-workshop/307131

That could have been me. I have made some changes to the image insertion code and I was playing around with that page when I did so.

Have you seen other pages with similar issues?


This one: http://www.summitpost.org/rattletale-wall/837951

But he has some code of his own inserted for the huge picture, so that may be the cause, but I doubt he'd have wanted the page to look that way.
Bob's Law: The rationality of a person is inversely proportional to the number of political and religious bumper stickers on his car. Around bumper-sticker warriors, smile, speak calmly, and get the hell away as fast as possible.
User Avatar
Bob Sihler
Forum Moderator
 
Posts: 7290
Joined: Mon Aug 23, 2004 3:20 pm
Location: Herndon, Virginia
Thanked: 1812 times in 1027 posts

The following user would like to thank Bob Sihler for this post
Montana Matt

Re: New Editor Feedback & Bug Reports

Postby Montana Matt » Tue Feb 12, 2013 8:02 pm


That was indeed a mess up I made to the code. Just found it and fixed it.
User Avatar
Montana Matt
Site Admin
 
Posts: 1128
Joined: Sun Apr 11, 2004 10:06 pm
Location: Ashland, Oregon, United States
Thanked: 340 times in 184 posts

Re: New Editor Feedback & Bug Reports

Postby Montana Matt » Tue Feb 12, 2013 9:41 pm

Alpinist wrote:Help! I edited my list of Online Gear Stores today and it broke all of the URLs. I pulled up the previous version through the View History link and tried editing it again using the Old Editor but the links are still broken. That's odd because the URLs appear when I'm editing the page but there are no hyperlinks when I save it...

Please let me know how to revert back to the previous version.

http://www.summitpost.org/online-gear-s ... ada/256792

Looked it this further. It looks like the HTML that creates the table and list of online stores is poorly formed. When it is passed into the new editor, it is done so through a Javascript function .html():
http://api.jquery.com/html/

Evidently that function tries to clean up poorly formed HTML. In this case, for some reason, it is moving your Anchor Text (the text that should be clickable) outside of the Anchor. That's why the "hyperlinks" are gone. The fix is simply to open up the document in the new editor, view the source HTML and move all of the anchor text back between the anchor tags. Or you can continue to use the old editor.
User Avatar
Montana Matt
Site Admin
 
Posts: 1128
Joined: Sun Apr 11, 2004 10:06 pm
Location: Ashland, Oregon, United States
Thanked: 340 times in 184 posts

Re: New Editor Feedback & Bug Reports

Postby Alpinist » Tue Feb 12, 2013 10:47 pm

Matt - I looked at the source code while the new editor was open. Here are the first couple of lines of code...

Code: Select all
<TABLE><br />
<table border=1 cellpadding=2><tr bgcolor=lightgrey><td align=left><font color=000066><b>Store Name</b></td><td align=center><font color=000066><b>Location</b></td><td align=center><font color=000066><b>Description</B></tr><tr><td align=left><font color=000066><br />
<br />
<a href=http://www.acmeclimbing.com/>ACME Climbing</a></td><td align=center><font color=000066>Spokane, WA</td><td align=center><font color=000066>Camping, climbing, footwear, snowsports, more</tr><tr><td align=left><font color=000066><br />


I don't see any problem with the URL tags. The only thing that looks different is the adition of "/" in the "<br>" tag. Is that causing the problem?

Is there any downside to just using the old editor? (Will that go away at some point in the future?)
User Avatar
Alpinist

 
Posts: 5999
Joined: Tue Jul 29, 2003 7:21 pm
Location: Kildeer, Illinois, United States
Thanked: 629 times in 428 posts

Re: New Editor Feedback & Bug Reports

Postby Josh Lewis » Wed Feb 13, 2013 12:17 am

Both <br> and </br> should work just fine. Having the slash is completely optional and is 100% harmless.
BTW, that HTML looks sloppy if you ask me. I could see there being problems with it (for example no closing tag for the font).
My Websites: Alpine Josh · Alpine Ascent · AceMaps
User Avatar
Josh Lewis

 
Posts: 2274
Joined: Thu Jan 06, 2011 11:12 pm
Location: Lynnwood, Washington, The Cloudiest Place on Earth, United States
Thanked: 472 times in 323 posts

The following user would like to thank Josh Lewis for this post
mrchad9

Re: New Editor Feedback & Bug Reports

Postby Montana Matt » Wed Feb 13, 2013 12:36 am

@Alpinist: Open it up in the new editor and take a look at how the HTML is cleaned up:
Code: Select all
<table border="1" cellpadding="2"><tbody><tr bgcolor="lightgrey"><td align="left"><font color="000066"><b>Store Name</b></font></td><td align="center"><font color="000066"><b>Location</b></font></td><td align="center"><font color="000066"><b>Description</b></font></td></tr><tr><td align="left"><font color="000066"><br>
<br>
<a href="http://www.acmeclimbing.com"></a>ACME Climbing</font></td><td align="center"><font color="000066">Spokane, WA</font></td><td align="center"><font color="000066">Camping, climbing, footwear, snowsports, more</font></td></tr><tr><td align="left"><font color="000066"><br>
<br>
<a href="http://www.alaskamountaineering.com"></a>Alaska Mountaineering and Hiking</font></td><td align="center"><font color="000066">Anchorage, AK</font></td><td align="center"><font color="000066">Camping, climbing, clothing, footwear, snowsports</font></td></tr><tr><td align="left"><font color="000066"><br>
<br>
<a href="http://www.alpenglowgear.com"></a>Alpenglow</font></td><td align="center"><font color="000066">Orono, ME</font></td><td align="center"><font color="000066">Camping, climbing, clothing, footwear, snowsports</font></td></tr><tr><td align="left"><font color="000066"><br>

I'm not sure what is causing the root of the problem because I haven't experimented with it at all. But Josh's guess about the non-closing of the <font> is a good one. As is the fact that none of the hrefs have double quotes around the URL.
User Avatar
Montana Matt
Site Admin
 
Posts: 1128
Joined: Sun Apr 11, 2004 10:06 pm
Location: Ashland, Oregon, United States
Thanked: 340 times in 184 posts

Re: New Editor Feedback & Bug Reports

Postby Catamount » Wed Feb 13, 2013 4:34 am

Well, crap. I am guessing it is an unfixable problem and I was half expecting it to happen at some point during the changes. When I asked that my original account (from 2005) be deleted in 2010, I moved all my submissions over to the Orphanage or - in the case of Trip Reports - a second account where the pages were simply stored. The Orphanage was actually created when I left. All of my photos were deleted but, with only a few exceptions, remained embedded on the pages. If you clicked on a photo on the page, you simply got a message saying "This page has been deleted." After I returned last year and made the second account my main account, I re-adopted my unadopted pages and brushed things up a bit but didn't re-submit the 200 or so photos that were nuked. The mountain pages and TRs stayed in tact through the conversion to SP3 but seem to have been broken in the switch over to the new page editor.

Any fix other at this point other than re-submitting all my photos?
User Avatar
Catamount

 
Posts: 301
Joined: Wed Mar 04, 2009 11:13 am
Location: Tech Valley, New York, United States
Thanked: 753 times in 490 posts

Re: New Editor Feedback & Bug Reports

Postby Montana Matt » Wed Feb 13, 2013 5:14 am

Catamount wrote:The mountain pages and TRs stayed in tact through the conversion to SP3 but seem to have been broken in the switch over to the new page editor.

The data for pages is stored in the database. The new editor can't "break" anything unless the pages are opened with the new editor, don't look right and then are saved. If the page doesn't look right when you open it with the new editor, use the old one.
User Avatar
Montana Matt
Site Admin
 
Posts: 1128
Joined: Sun Apr 11, 2004 10:06 pm
Location: Ashland, Oregon, United States
Thanked: 340 times in 184 posts

Re: New Editor Feedback & Bug Reports

Postby Catamount » Wed Feb 13, 2013 5:24 am

I guess I didn't explain it well enough. Here is one example of many:

http://www.summitpost.org/borah-and-kings-solo/429278
User Avatar
Catamount

 
Posts: 301
Joined: Wed Mar 04, 2009 11:13 am
Location: Tech Valley, New York, United States
Thanked: 753 times in 490 posts

Re: New Editor Feedback & Bug Reports

Postby Josh Lewis » Wed Feb 13, 2013 5:43 am

Matt, those images are destroyed. As in non existent in the database (nor is there a photo in the directory). I tested this by playing with the id's and the image sources. You mentioned that the images linked to deleted pages before? So is it possible those images existed as just images without a image page (Example of Image Page)? Perhaps some Spring cleaning took place to remove images that had no pages (removal of "orphan images"). My site has a removal tool for images in the directory without a page attached to it.

What do I mean by image attached to it? Let's pretend the image page example above is deleted but the image is stored in the image file directory. The raw image would still exist, but could not be queried when doing a search, nor voted on, nor a page displaying it. Typically when you delete a image page it deletes the original and such, but sometimes I've seen cases where other sized images lingered.
My Websites: Alpine Josh · Alpine Ascent · AceMaps
User Avatar
Josh Lewis

 
Posts: 2274
Joined: Thu Jan 06, 2011 11:12 pm
Location: Lynnwood, Washington, The Cloudiest Place on Earth, United States
Thanked: 472 times in 323 posts

Re: New Editor Feedback & Bug Reports

Postby Catamount » Wed Feb 13, 2013 6:26 am

Yes, exactly, Josh. The raw images had remained on the mountain/trip report pages even though the image page no-longer existed. That had been the case up until I noticed today that the raw images are now all gone.

It is what it is. As they stand right now, the involved pages are garbage and I don't think I am going to go through the hassle of reconstruction. There are 3 mountain pages and 9 trip reports that I am likely going to retire to my personal scrapbook. They've had a good run and gotten a ton of hits so I am not upset at all about it. The 3 mountain pages are fairly obscure with only a few people signing each log so deletion shouldn't really upset anyone.
User Avatar
Catamount

 
Posts: 301
Joined: Wed Mar 04, 2009 11:13 am
Location: Tech Valley, New York, United States
Thanked: 753 times in 490 posts

Re: New Editor Feedback & Bug Reports

Postby Montana Matt » Wed Feb 13, 2013 2:40 pm

Catamount wrote:I guess I didn't explain it well enough. Here is one example of many:

http://www.summitpost.org/borah-and-kings-solo/429278

I see. None of the image tags are being parsed. Took me a while to figure out what was going on (should have read Josh's post above), but this has nothing to do with the new editor.

All of the embedded images in that page have been deleted. That's why none of the images are being displayed. This is the list of image IDs:
429282,429280,429284,429285,427363,429326,429328,429327,429330,429331,429324

All are deleted now. The image parser won't replace the image tags unless the images are actually still in the database.
Catamount wrote:That had been the case up until I noticed today that the raw images are now all gone.

Yes, I recently deleted all 100,000+ images from the database that had been deleted from the site.
Catamount wrote:There are 3 mountain pages and 9 trip reports that I am likely going to retire to my personal scrapbook.

I'd say just leave them and remove the images...
User Avatar
Montana Matt
Site Admin
 
Posts: 1128
Joined: Sun Apr 11, 2004 10:06 pm
Location: Ashland, Oregon, United States
Thanked: 340 times in 184 posts

PreviousNext

Return to Site Feedback

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: No registered users and 0 guests

© 2006-2013 SummitPost.org. All Rights Reserved.