Re: SPv3 formatting problems
Posted: Tue Jan 29, 2013 8:33 pm
The image class name was already changed yesterday morning which I knew that would break stuff. So I decided that "we might as well go all the way" and have a good name associated with the class (the class name is "image"). This in turn makes it easier for manual placements of panoramas. The small price was this period of inconvenience which only applies to those who recently viewed SummitPost (the last few days). I expect this to be the last major CSS change for a long time (this already happened). There are still additions that need to be made, but they all are minor and should not have such a big impact as changing the class name.
One might argue "but Josh, the people who made panoramas back in the day had a class of 'thumb' which will break". True, but the format was changed to a DIV, so even if the class was not renamed it would break. However, Matt could easily add backwards compatibility code. That depends on how much folks want it, how much stuff breaks, and whether or not that should be considered "more clutter in the CSS code. Personally I'd be fine with it.
One might argue "but Josh, the people who made panoramas back in the day had a class of 'thumb' which will break". True, but the format was changed to a DIV, so even if the class was not renamed it would break. However, Matt could easily add backwards compatibility code. That depends on how much folks want it, how much stuff breaks, and whether or not that should be considered "more clutter in the CSS code. Personally I'd be fine with it.