Page 6 of 6

Re: SPv3 formatting problems

PostPosted: Tue Jan 29, 2013 8:33 pm
by Josh Lewis
The image class name was already changed yesterday morning which I knew that would break stuff. So I decided that "we might as well go all the way" and have a good name associated with the class (the class name is "image"). This in turn makes it easier for manual placements of panoramas. The small price was this period of inconvenience which only applies to those who recently viewed SummitPost (the last few days). I expect this to be the last major CSS change for a long time (this already happened). There are still additions that need to be made, but they all are minor and should not have such a big impact as changing the class name.

One might argue "but Josh, the people who made panoramas back in the day had a class of 'thumb' which will break". True, but the format was changed to a DIV, so even if the class was not renamed it would break. However, Matt could easily add backwards compatibility code. That depends on how much folks want it, how much stuff breaks, and whether or not that should be considered "more clutter in the CSS code. Personally I'd be fine with it.

Re: SPv3 formatting problems

PostPosted: Tue Jan 29, 2013 9:35 pm
by mrchad9
That is a bigger inconvenience no?

Re: SPv3 formatting problems

PostPosted: Tue Jan 29, 2013 10:01 pm
by mrchad9
Catamount wrote:
mrchad9 wrote:That is a bigger inconvenience no?


Given that there are less than 1,000 views of this thread and many of those are repeat visitors, it would seem that many people are likely experiencing the formatting problems described above and have no idea why. I would think the goal would be a seamless transition even if it meant the site being down for a few hours.

People are about to have a better idea as to why things are changing, and what to do if they have issues. Not too long from now.

Re: SPv3 formatting problems

PostPosted: Tue Jan 29, 2013 10:34 pm
by Josh Lewis
Catamount wrote:Wouldn't it be normal practice to take the site down during such a maintenance period?


If Matt did this, SP would have been shut down many times this last week. :lol: Lots of small corrections where made even when the site went live. Even this morning the captions no longer have the links underlined so that it looks better. Don't worry, normal links still have the underline.

BTW - Shutting down SP would have done nothing to stop this issue, as Matt mentioned somewhere else changing the name of the style sheet would have fixed this. Here's a simple way to think of it, a piece of data on your computer is telling SP to work a certain way (format) and now it doesn't know what to do with images inside of the "image" class. :wink: But as I said, this should be the last major change. Everything else should be minor fixes. :) So I wouldn't expect this issue to happen for a few more years... hopefully never again.

Re: SPv3 formatting problems

PostPosted: Wed Jan 30, 2013 3:31 am
by Josh Lewis
When the transition was made (before I requested the name change) the tables with the thumb class were broken. My panorama's as seen on this page broke: http://www.summitpost.org/mount-logan/154947
I don't mind fixing this, but it's a fact of life. This had to do with the fact that we swapped from tables to DIVs.

So look inside this file:
http://www.summitpost.org/site/css/main-minified.css
Type control + F which should bring up the search. Type "table.thumb" which you'll get a few results. But you will see that there is nothing in the code telling it to add padding nor to center the text for tables with the class "thumb".

Re: SPv3 formatting problems

PostPosted: Wed Jan 30, 2013 7:58 pm
by Brian C
So I've been trying to figure this out. Now if I use the standard SP "insert image" tab and put 2 photos next to each other using the align:center:medium setting it requires side-to-side scrolling. I don't remember this being an issue before. Is there a way to have this work without going into move complicated code on the photos to reduce their size?

Re: SPv3 formatting problems

PostPosted: Wed Jan 30, 2013 10:13 pm
by Josh Lewis
I'm guessing this is caused by padding. What's your screen resolution? I might have a solution for you.

Re: SPv3 formatting problems

PostPosted: Wed Jan 30, 2013 10:30 pm
by Brian C
1280x1024

Re: SPv3 formatting problems

PostPosted: Thu Jan 31, 2013 4:40 am
by Scott
I added a few route pages today and am getting some weird stuff when using "Find Image" under the "Primary Image ID". Entering the photo id works fine, but using the Find Image sometimes works and sometimes doesn't. Even when it works, a huge secondary screen pops up and you have to look for where to add the id.

I'm not sure if it is just me or if others are having the same problem (maybe give it a test).

Re: SPv3 formatting problems

PostPosted: Wed Feb 06, 2013 5:14 am
by Josh Lewis
Scott, are you still having these issues? The insert button will change coming up (at least how it works in some regards).

Re: SPv3 formatting problems

PostPosted: Wed Feb 06, 2013 6:33 pm
by Scott
Matt, after playing with it a bit, it works with Internet Explorer. It appears not to work with Google Chrome.

When I click on "Find Image" under "Primary Image ID", here's what I get under Google Chrome:

Re: SPv3 formatting problems

PostPosted: Wed Feb 06, 2013 7:12 pm
by Bob Sihler
I get the same problem in Chrome. It's solved by scrolling down and then back up, in which case the correct field appears where it should, but it's annoying.

Re: SPv3 formatting problems

PostPosted: Wed Feb 06, 2013 10:06 pm
by Josh Lewis
Matt, if you send me the CSS code that you removed to fix this issue I could probably figure out a way to properly reinstate it to make it look better without causing issues. :)