New Editor Feedback & Bug Reports

Suggestions and comments about SummitPost's features, policies, and procedures. Post bugs here.
User Avatar
Bob Sihler
Forum Moderator
 
Posts: 8438
Joined: Mon Aug 23, 2004 3:20 pm
Thanked: 2690 times in 1492 posts

Re: New Editor Feedback & Bug Reports

by Bob Sihler » Tue Feb 12, 2013 7:27 pm

mrchad9 wrote:How is it that your page workshop has 16 votes?


As you once said, asking people not to vote is a sure way to get them to. :wink:
"Alcohol is like love. The first kiss is magic, the second is intimate, the third is routine. After that you take the girl's clothes off."

--Terry Lennox, The Long Goodbye (Raymond Chandler)

The following user would like to thank Bob Sihler for this post
mrchad9

User Avatar
Bob Sihler
Forum Moderator
 
Posts: 8438
Joined: Mon Aug 23, 2004 3:20 pm
Thanked: 2690 times in 1492 posts

Re: New Editor Feedback & Bug Reports

by Bob Sihler » Tue Feb 12, 2013 7:56 pm

Montana Matt wrote:
Bob Sihler wrote:Yikes! Whatever was done has made a mess of my page: http://www.summitpost.org/page-workshop/307131

That could have been me. I have made some changes to the image insertion code and I was playing around with that page when I did so.

Have you seen other pages with similar issues?


This one: http://www.summitpost.org/rattletale-wall/837951

But he has some code of his own inserted for the huge picture, so that may be the cause, but I doubt he'd have wanted the page to look that way.
"Alcohol is like love. The first kiss is magic, the second is intimate, the third is routine. After that you take the girl's clothes off."

--Terry Lennox, The Long Goodbye (Raymond Chandler)

User Avatar
Alpinist

 
Posts: 6519
Joined: Tue Jul 29, 2003 7:21 pm
Thanked: 875 times in 589 posts

Re: New Editor Feedback & Bug Reports

by Alpinist » Tue Feb 12, 2013 10:47 pm

Matt - I looked at the source code while the new editor was open. Here are the first couple of lines of code...

Code: Select all
<TABLE><br />
<table border=1 cellpadding=2><tr bgcolor=lightgrey><td align=left><font color=000066><b>Store Name</b></td><td align=center><font color=000066><b>Location</b></td><td align=center><font color=000066><b>Description</B></tr><tr><td align=left><font color=000066><br />
<br />
<a href=http://www.acmeclimbing.com/>ACME Climbing</a></td><td align=center><font color=000066>Spokane, WA</td><td align=center><font color=000066>Camping, climbing, footwear, snowsports, more</tr><tr><td align=left><font color=000066><br />


I don't see any problem with the URL tags. The only thing that looks different is the adition of "/" in the "<br>" tag. Is that causing the problem?

Is there any downside to just using the old editor? (Will that go away at some point in the future?)

User Avatar
Josh Calico

 
Posts: 3355
Joined: Thu Jan 06, 2011 11:12 pm
Thanked: 1045 times in 644 posts

Re: New Editor Feedback & Bug Reports

by Josh Calico » Wed Feb 13, 2013 12:17 am

Both <br> and </br> should work just fine. Having the slash is completely optional and is 100% harmless.
BTW, that HTML looks sloppy if you ask me. I could see there being problems with it (for example no closing tag for the font).

The following user would like to thank Josh Calico for this post
mrchad9

User Avatar
Josh Calico

 
Posts: 3355
Joined: Thu Jan 06, 2011 11:12 pm
Thanked: 1045 times in 644 posts

Re: New Editor Feedback & Bug Reports

by Josh Calico » Wed Feb 13, 2013 5:43 am

Matt, those images are destroyed. As in non existent in the database (nor is there a photo in the directory). I tested this by playing with the id's and the image sources. You mentioned that the images linked to deleted pages before? So is it possible those images existed as just images without a image page (Example of Image Page)? Perhaps some Spring cleaning took place to remove images that had no pages (removal of "orphan images"). My site has a removal tool for images in the directory without a page attached to it.

What do I mean by image attached to it? Let's pretend the image page example above is deleted but the image is stored in the image file directory. The raw image would still exist, but could not be queried when doing a search, nor voted on, nor a page displaying it. Typically when you delete a image page it deletes the original and such, but sometimes I've seen cases where other sized images lingered.

User Avatar
Josh Calico

 
Posts: 3355
Joined: Thu Jan 06, 2011 11:12 pm
Thanked: 1045 times in 644 posts

Re: New Editor Feedback & Bug Reports

by Josh Calico » Wed Feb 13, 2013 8:43 pm

Montana Matt wrote:
Catamount wrote:(should have read Josh's post above)


Matt Matt... Always trying to figure it out on your own before looking at the evidence folks give you. :wink: It makes your job harder.

User Avatar
Alpinist

 
Posts: 6519
Joined: Tue Jul 29, 2003 7:21 pm
Thanked: 875 times in 589 posts

Re: New Editor Feedback & Bug Reports

by Alpinist » Wed Feb 13, 2013 10:14 pm

Montana Matt wrote:@Alpinist: Open it up in the new editor and take a look at how the HTML is cleaned up:
Code: Select all
<table border="1" cellpadding="2"><tbody><tr bgcolor="lightgrey"><td align="left"><font color="000066"><b>Store Name</b></font></td><td align="center"><font color="000066"><b>Location</b></font></td><td align="center"><font color="000066"><b>Description</b></font></td></tr><tr><td align="left"><font color="000066"><br>
<br>
<a href="http://www.acmeclimbing.com"></a>ACME Climbing</font></td><td align="center"><font color="000066">Spokane, WA</font></td><td align="center"><font color="000066">Camping, climbing, footwear, snowsports, more</font></td></tr><tr><td align="left"><font color="000066"><br>
<br>
<a href="http://www.alaskamountaineering.com"></a>Alaska Mountaineering and Hiking</font></td><td align="center"><font color="000066">Anchorage, AK</font></td><td align="center"><font color="000066">Camping, climbing, clothing, footwear, snowsports</font></td></tr><tr><td align="left"><font color="000066"><br>
<br>
<a href="http://www.alpenglowgear.com"></a>Alpenglow</font></td><td align="center"><font color="000066">Orono, ME</font></td><td align="center"><font color="000066">Camping, climbing, clothing, footwear, snowsports</font></td></tr><tr><td align="left"><font color="000066"><br>

I'm not sure what is causing the root of the problem because I haven't experimented with it at all. But Josh's guess about the non-closing of the <font> is a good one. As is the fact that none of the hrefs have double quotes around the URL.

Matt/Josh, thanks for your guidance. I got rid of the font tags for each cell and replaced them with the <table color> tag. However, when I added double quotes to the URLs within the table, for some reason it adds "http://www.summitpost.org" to all of the links when you click on them. For example, if you click on REI.com, it takes you to "www.summitpost.org/www.rei.com", which obviously doesn't exist... The quotes work fine for the links at the bottom of the page but not the URLs that are contained in a table.

For now, I omited the quotes for the URLs in the table. That's the only way it seems to work.

User Avatar
Scott
Forum Moderator
 
Posts: 8405
Joined: Thu Aug 21, 2003 1:03 pm
Thanked: 1169 times in 616 posts

Re: New Editor Feedback & Bug Reports

by Scott » Thu Feb 14, 2013 8:06 pm

I am having some serious issues with my trip report!

http://www.summitpost.org/a-return-to-t ... aya/838418

Neither editor works. Please help.

User Avatar
Scott
Forum Moderator
 
Posts: 8405
Joined: Thu Aug 21, 2003 1:03 pm
Thanked: 1169 times in 616 posts

Re: New Editor Feedback & Bug Reports

by Scott » Thu Feb 14, 2013 8:11 pm

Update:

I deleted everything and am starting over from cut and paste. Is there any way to use the old editor without having it add all this extra code stuff while adding photos? Trying to do something simple like add captions ruins the whole reports. If one typo is present it arranges all the photos/text and you can't go back and fix it like you used to.

User Avatar
Scott
Forum Moderator
 
Posts: 8405
Joined: Thu Aug 21, 2003 1:03 pm
Thanked: 1169 times in 616 posts

Re: New Editor Feedback & Bug Reports

by Scott » Thu Feb 14, 2013 9:17 pm

I'm guessing you mean the "new editor" where you say "old editor" in this sentence?


No.

When I go into old editor, I am getting this:

<div align="center" class="image" style="width: 506px;"><a href="/thamserku/833072"><img alt="Thamserku" height="375" width="500" src="/images/medium/833072.JPG"></a>
<span class="caption">Thamserku finally breaks through the clouds.</span></div>

Instead of this:

[img:833073:aligncenter:medium:Sunset on Ama Dablam from Tengboche.]

I'm guessing that once you use the new editor once, it reverts everything to the former, even when using the old editor.

I need a little more information Scott and, preferably, an example of the problem. I've not had any problems adding captions.


I should have screen shot it, but I'll explain the best I can. I was going to leave it the way it was to get some help fixing, but I just ended up reposting everything.

Something I did in the new editor (and I don't know what) caused the entire rest of the trip report to show up as a photo caption. I went in to try and edit this and when I couldn't figure it out, it deleted the photo. In turn, rather than keeping all the photos in their proper sections, it shifted all of them into the next section up.

In the past, the old editor, the same thing would happen if there was an invalid photo id (typo) in one of the image tags, i.e., [img:833073:aligncenter:medium:]. Once the image tag was fixed in the old system, all photos would then display in their proper locations (this is what I meant by I couldn't go back and fix it like I used to be able to do). This time, using the new editor, the shift took place (from whatever I did) and even when I reverted back to the old editor, it physically moved all the photos into the wrong section.

I tried to cut and paste them into the proper sections (old editor), but something was causing most of the report to show up as a photo caption. I couldn't see anything different in the long code that caused this, so I dumped all the photos and copy/pasted much of the text and started over.

Does that explain anything? Sorry I didn't screen shot it. Any idea what happened (whatever initially happened, it did so when I was trying to add a photo caption)?

Thanks Matt.

User Avatar
Josh Calico

 
Posts: 3355
Joined: Thu Jan 06, 2011 11:12 pm
Thanked: 1045 times in 644 posts

Re: New Editor Feedback & Bug Reports

by Josh Calico » Fri Feb 15, 2013 12:06 am

Not sure if this is possible, but an undo button would really come in handy. I haven't needed one yet, but I'm sure I'll stumble across cases where it would be nice. I'm sure many folks would use it. The JCK editor I suggested in the past has this feature. :wink:

As for Scott and everyone else... all right, I'll get working on the better styling for transitioning from the new editor to the old. What will this do? Make it easier to find the old editor button and make it look nice. Let me think on this.

User Avatar
mrchad9

 
Posts: 4538
Joined: Thu Jul 02, 2009 12:01 am
Thanked: 1335 times in 908 posts

Re: New Editor Feedback & Bug Reports

by mrchad9 » Fri Feb 15, 2013 12:16 am

Undo buttons are usually pretty complicated based on my understanding. Requires a whole new process to track every single change as it is made, and remember all of them.

User Avatar
lcarreau

 
Posts: 4226
Joined: Thu Sep 06, 2007 10:27 pm
Thanked: 1897 times in 1414 posts

Re: New Editor Feedback & Bug Reports

by lcarreau » Fri Feb 15, 2013 12:36 am

Ummm ... I have a Bug Report ...

Image

Actually, you guys are doing great ... please keep up the fine work!
"Turkey Vultures always vomit when they get nervous."

User Avatar
rgg
Forum Moderator
 
Posts: 862
Joined: Sat Oct 02, 2010 7:15 pm
Thanked: 192 times in 154 posts

Re: New Editor Feedback & Bug Reports

by rgg » Fri Feb 15, 2013 1:26 pm

Josh Lewis wrote:Not sure if this is possible, but an undo button would really come in handy.


Ctrl+Z works fine as UNDO, and Ctrl+Y as a REDO. I don't know how big the redo buffer of the editor is, but you can undo (and redo) several actions. And since the editor has the functionality, adding buttons for it shouldn't be all that difficult. Whether we want them or not, that's a whole different question. Personally, I don't find them necessary. But then again, I've stored all these frequently used shortcuts in the back of my head somewhere...

User Avatar
distressbark

 
Posts: 32
Joined: Fri Nov 07, 2008 8:55 pm
Thanked: 7 times in 6 posts

Re: New Editor Feedback & Bug Reports

by distressbark » Fri Feb 15, 2013 4:59 pm

Montana Matt wrote:
Matt Lemke wrote:when you resize a photo (say down to 200px) the photo gets compressed and looks blurry (trust me this does happen)

It shouldn't happen in any modern browser. Can you show me an example?


Montana Matt, check out my route page that I'm trying to reformat using the new editor: http://www.summitpost.org/view_object.php?object_id=463934&confirm_post=7. Scroll down about half way and look at the vertical photo on the right titled "Cracker Peak (L) & Mount Siyeh (R)". I believe the photo inserted at a default width=500px; when I changed it to 300px, the photo showed up very, very blurry on the page. Thanks for looking into this.

PreviousNext

Return to Site Feedback

 


  • Related topics
    Replies
    Views
    Last post

Who is online

Users browsing this forum: No registered users and 0 guests