Also, when a calculation is done on that page the results zero out and we return to the top of the page. This makes the calculation function useless. Is this likely a code issue or does summitpost not support calculations anymore. It never used to do this and I'm not sure that I changed anything.

Klenke wrote:Is this likely a code issue or does summitpost not support calculations anymore.

It's a code issue. The button is submitting and reloading the page. I can see the calculation working though before the page refreshes.

I just did some research and figured out a fix. It should work now. Let me know if it doesn't.

Klenke wrote:Back to the banner photo image being too big, Matt:
Can't we fix this as previously mentioned?

I've come back to thinking about this several times and I can't figure out a good solution if we want the image to cover the entire page regardless of size (which we do because it looks best on the most devices). The solution you outlined to give people choices would still result in images not looking good in some screen sizes. The way it is set up now, it looks good on most common screen sizes but, depending on the photo chosen as the cover image, not always.

I think we are going to have to accept that the cover image functions differently now and choose them appropriately. If you'd like help finding or creating a different cover image that will work better for that page, I would be happy to help.

Or, if you can point out another site with a responsive design where that particular cover image would always looks good no matter the screen size, I could leverage their HTML/CSS design.

Thanks for the code fix! What was the fix? Something in my html code or something with the way the website works in general? That is, is it something I need to be aware of for future html coding I might do?

The banner thing:
Can you allow the user to select between a) having a banner image 'stretched' as is done now for all primary images and b) not having the image be bannered? For the latter, the primary image would get put in a constrained box that is not stretched.

Klenke wrote:Thanks for the code fix! What was the fix? Something in my html code or something with the way the website works in general? That is, is it something I need to be aware of for future html coding I might do?

I believe the source of the problem came from a change in the way HTML5 works with buttons. Now you must specify that type="button" on any button, otherwise it will submit the form and trigger a page load. See here:
https://stackoverflow.com/questions/932 ... ting-forms

Klenke wrote:Can you allow the user to select between a) having a banner image 'stretched' as is done now for all primary images and b) not having the image be bannered? For the latter, the primary image would get put in a constrained box that is not stretched.

Yes, I think that would be possible. But the problem is, how would we constrain the photo so that it would display well on all screens? Remember that most mobile devices aren't wider than a few hundred pixels. If you fix the image at some width, I don't think it will render correctly on smaller screens.

We are using this service now to serve SummitPost images:
https://www.imgix.com/

They allow for dynamically changing images on the fly by simply passing along arguments in the URL of the image. I think we could use some of the parameters available to accommodate most images, but I am not entirely sure that they would look good on all screen sizes.

See these parameters:
https://docs.imgix.com/apis/url/size
https://docs.imgix.com/apis/url/size/crop
https://docs.imgix.com/apis/url/size/fit

I can't get rid of the huge gap above the dinosaur track photo near the bottom of this page:

https://www.summitpost.org/2019-trip-log/1028331

I'm not sure what it is, but I can't delete the space.

Scott wrote:I can't get rid of the huge gap above the dinosaur track photo near the bottom of this page:

https://www.summitpost.org/2019-trip-log/1028331

I'm not sure what it is, but I can't delete the space.

Weird. It was only showing in the new editor, not on the live page. There was some extraneous HTML in there that was causing the problem. It should be fixed now though!

Not sure whether this is intended but the Table of contents now seems to be located at the bottom of each page. I'm wondering if its a bug but who would want to scroll down all the way to see the toc?

Also the geographical breadcrumbs (parents and children) have disappeared. Which is a bit of a pity as they were a good indication of where the mountain in question was.

Gangolf Haub wrote:Not sure whether this is intended but the Table of contents now seems to be located at the bottom of each page. I'm wondering if its a bug but who would want to scroll down all the way to see the toc?

The pages I see still have them at the top of the page.

Gangolf Haub wrote:Not sure whether this is intended but the Table of contents now seems to be located at the bottom of each page. I'm wondering if its a bug but who would want to scroll down all the way to see the toc?

Can you post a link to the page where you see that happening? I'll take a look. It could be something else that is causing the TOC to drop to the bottom. Like Scott, I've been seeing them at the top of the pages.

Perhaps you are looking on a narrower screen (<1200 pixels wide)? If so, the TOC does drop below the content. We weren't sure where to put it if we kept it at the top of the page. But if there is a better place to put it on very narrow screens, please make a suggestion and we can see if it works to move it up at the top of the page.

Gangolf Haub wrote:Also the geographical breadcrumbs (parents and children) have disappeared. Which is a bit of a pity as they were a good indication of where the mountain in question was.

I'm not sure what you mean by "geographical breadcrumbs." Do you mean the sidebar "Geography" section on main pages? Or the lat/lon coordinates? Or the state/province, country, continent information? Or something else in the search results pages?

I take everything back. You were right, I was on a ridiculous resolution. Problem is, I took part in the Heidelberg half marathon on sunday and 600 yards before the finish line I fell, smashing my glasses (and getting two lacerations - my face is real colourful). And to be able to read anything with my spare glasses I have to crank up the browser zoom.

Anfd the breadcrumbs were supoosed to be the links "home - parent - child" at the top of each page (like home - Sardinia - Monte Albo on the Monte Albo page). But everything is there if you use sensible resolution

Sorry to hear about your fall, but happy to hear that everything is displaying OK on the site!

Matt, I see you have somehow changed the code for inline images. It turns out that all of my panoramas are now completely off and I don't see how I will be able to fix them all.

Example:
https://www.summitpost.org/view_object. ... id=1030744

Code:

Code: Select all

<center><table class="thumb"><tbody><tr><td><div><div style="width:770px;height:690px;overflow:auto;"><img src="https://www.summitpost.org/images/original/1030757.jpg"></div><div class="magnify" style="float: right; margin-top: 5px;"><a href="/view_object.php?object_id=1030757" title="View Pano"> <img style="" src="/images/layout/abby/magnify.gif" alt="Enlarge"></a></div>The Sao Vicente Basin and the Central Range seen from Pico Bica da Cana</div></td></tr></tbody></table></center>

It's quite frustrating actually.

Hi Gangolf,

Thanks for reporting this. I am looking at the problem but can't see what exactly the cause is for the fact that the images aren't showing at their maximum resolution.

If I right-click on the image and open it in a new window, it is very large:
https://sp-images.summitpost.org/103075 ... 1095ff2cb5

So there must be some sort of CSS limitation with the wrapping div that is preventing the image from going to max resolution. Ah yes...I see the issue now...it is with img max-width: 100% and the outer div being set at 770px width, so the image is limited to that width as well.

Hmm, I can't think of a way to fix that off the top of my head. A change was made to the CSS so that all images are responsive now, which is very important for proper responsive display of pages on all devices and to achieve that it required setting max-width: 100%.

Let me do some Googling to see if I can find a solution for displaying "responsive" panorama images. I am assuming instead of the image being shrunk to fit the width of the screen, the behavior you'd like to see is that there is a scroll bar across the bottom as it behaved in the past?